[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 05/14] machine: Improve the error reporting of smp parsin
Daniel P . Berrangé
Re: [PATCH v11 05/14] machine: Improve the error reporting of smp parsing
Tue, 28 Sep 2021 11:13:43 +0100
On Tue, Sep 28, 2021 at 11:57:46AM +0800, Yanan Wang wrote:
> We have two requirements for a valid SMP configuration:
> the product of "sockets * cores * threads" must represent all the
> possible cpus, i.e., max_cpus, and then must include the initially
> present cpus, i.e., smp_cpus.
> So we only need to ensure 1) "sockets * cores * threads == maxcpus"
> at first and then ensure 2) "maxcpus >= cpus". With a reasonable
> order of the sanity check, we can simplify the error reporting code.
> When reporting an error message we also report the exact value of
> each topology member to make users easily see what's going on.
> Signed-off-by: Yanan Wang <firstname.lastname@example.org>
> Reviewed-by: Andrew Jones <email@example.com>
> Reviewed-by: Pankaj Gupta <firstname.lastname@example.org>
> hw/core/machine.c | 22 +++++++++-------------
> hw/i386/pc.c | 24 ++++++++++--------------
> 2 files changed, 19 insertions(+), 27 deletions(-)
Reviewed-by: Daniel P. Berrangé <email@example.com>
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v11 00/14] machine: smp parsing fixes and improvement, Yanan Wang, 2021/09/27
- [PATCH v11 01/14] machine: Deprecate "parameter=0" SMP configurations, Yanan Wang, 2021/09/27
- [PATCH v11 02/14] machine: Minor refactor/fix for the smp parsers, Yanan Wang, 2021/09/27
- [PATCH v11 05/14] machine: Improve the error reporting of smp parsing, Yanan Wang, 2021/09/27
- [PATCH v11 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split, Yanan Wang, 2021/09/27
- [PATCH v11 08/14] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/09/27
- [PATCH v11 06/14] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg, Yanan Wang, 2021/09/27
- [PATCH v11 03/14] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/09/27