[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 14/14] machine: Put all sanity-check in the generic SMP p
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v11 14/14] machine: Put all sanity-check in the generic SMP parser |
|
Date: |
Tue, 28 Sep 2021 11:38:07 +0100 |
|
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Tue, Sep 28, 2021 at 11:57:55AM +0800, Yanan Wang wrote:
> Put both sanity-check of the input SMP configuration and sanity-check
> of the output SMP configuration uniformly in the generic parser. Then
> machine_set_smp() will become cleaner, also all the invalid scenarios
> can be tested only by calling the parser.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
> Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
> ---
> hw/core/machine.c | 63 +++++++++++++++++++++++------------------------
> 1 file changed, 31 insertions(+), 32 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v11 11/14] machine: Make smp_parse generic enough for all arches, (continued)
- [PATCH v11 10/14] machine: Tweak the order of topology members in struct CpuTopology, Yanan Wang, 2021/09/27
- [PATCH v11 13/14] machine: Move smp_prefer_sockets to struct SMPCompatProps, Yanan Wang, 2021/09/27
- [PATCH v11 12/14] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/09/27
- [PATCH v11 14/14] machine: Put all sanity-check in the generic SMP parser, Yanan Wang, 2021/09/27
- [PATCH v11 04/14] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/09/27