[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 20/22] qapi: introduce x-query-irq QMP command

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 20/22] qapi: introduce x-query-irq QMP command
Date: Tue, 2 Nov 2021 15:57:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 10/28/21 17:54, Daniel P. Berrangé wrote:
> This is a counterpart to the HMP "info irq" command. It is being
> added with an "x-" prefix because this QMP command is intended as an
> adhoc debugging tool and will thus not be modelled in QAPI as fully
> structured data, nor will it have long term guaranteed stability.
> The existing HMP command is rewritten to call the QMP command.
> This command is unable to use the pre-existing HumanReadableText,
> because if 'common.json' is included into 'machine-target.json'
> the static marshalling method for HumanReadableText will be reported
> as unused by the compiler on all architectures except s390x.
> Possible options were
>  1 Support 'if' conditionals on 'include' statements in QAPI
>  2 Add further commands to 'machine-target.json' that use
>    HumanReadableText, such that it has at least one usage
>    on all architecture targets.
>  3 Duplicate HumanReadableText as TargetHumanReadableText
>    adding conditions
> This patch takes option (3) in the belief that we will eventually
> get to a point where option (2) happens, and TargetHumanReadableText
> can be removed again.

Outdated description from v2, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  hmp-commands-info.hx |  2 +-
>  monitor/hmp-cmds.c   | 38 --------------------------------------
>  monitor/qmp-cmds.c   | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  qapi/machine.json    | 12 ++++++++++++
>  4 files changed, 57 insertions(+), 39 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]