[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/tcg/s390x: Fix the exrl-trt* tests with Clang

From: Richard Henderson
Subject: Re: [PATCH] tests/tcg/s390x: Fix the exrl-trt* tests with Clang
Date: Tue, 1 Mar 2022 08:19:26 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/28/22 23:24, Thomas Huth wrote:
The exrl-trt* tests use two pre-initialized variables for the
results of the assembly code:

     uint64_t r1 = 0xffffffffffffffffull;
     uint64_t r2 = 0xffffffffffffffffull;

But then the assembly code copies over the full contents
of the register into the output variable, without taking
care of this pre-initialized values:

         "    lgr %[r1],%%r1\n"
         "    lgr %[r2],%%r2\n"

The code then finally compares the register contents to
a value that apparently depends on the pre-initialized values:

     if (r2 != 0xffffffffffffffaaull) {
         write(1, "bad r2\n", 7);
         return 1;

This all works with GCC, since the 0xffffffffffffffff got into
the r2 register there by accident, but it fails completely with

Let's fix this by declaring the r1 and r2 variables as proper
register variables instead, so the pre-initialized values get
correctly passed into the inline assembly code.

Signed-off-by: Thomas Huth<thuth@redhat.com>
  tests/tcg/s390x/exrl-trt.c  | 8 +++-----
  tests/tcg/s390x/exrl-trtr.c | 8 +++-----
  2 files changed, 6 insertions(+), 10 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]