[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] Allow returning EventNotifier's wfd

From: Paolo Bonzini
Subject: Re: [PATCH 1/2] Allow returning EventNotifier's wfd
Date: Wed, 2 Mar 2022 18:09:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 3/2/22 17:06, Stefan Hajnoczi wrote:
I agree. In fact, that's what I implemented in the first place. I
changed to this version in which event_notifier_get_fd() is extended
because it feels more "correct". But yes, the pragmatic option would
be adding a new event_notifier_get_wfd().

I'll wait for more reviews, and unless someone voices against it, I'll
respin the patches with that strategy (I already have it around here).
I had the same thought looking through the patch before I read Alex's
suggestion. A separate get_wfd() function makes sense to me.

And that's four with me. :) It's not just pragmatic, I cannot imagine a case where the caller doesn't know exactly which of the two file descriptors they want.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]