[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 1/2] s390x/cpu_models: drop "msa5" from the TCG "max" mode

From: Thomas Huth
Subject: Re: [PATCH v1 1/2] s390x/cpu_models: drop "msa5" from the TCG "max" model
Date: Tue, 22 Mar 2022 17:41:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0

On 22/03/2022 12.22, David Hildenbrand wrote:
We don't include the "msa5" feature in the "qemu" model because it
generates a warning. The PoP states:

"The message-security-assist extension 5 requires
the secure-hash-algorithm (SHA-512) capabilities of
the message-security-assist extension 2 as a prereq-
uisite. (March, 2015)"

As SHA-512 won't be supported in the near future, let's just drop the
feature from the "max" model. This avoids the warning and allows us for
making the "max" model match the "qemu" model (except for compat
machines). We don't lose much, as we only implement the function stubs
for MSA, exclusing any real subfunctions.

(but no need to respin just because of this)

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/897
Signed-off-by: David Hildenbrand <david@redhat.com>
  target/s390x/gen-features.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 22846121c4..7b4430f9de 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -743,8 +743,6 @@ static uint16_t qemu_LATEST[] = {
  /* add all new definitions before this point */
  static uint16_t qemu_MAX[] = {
-    /* generates a dependency warning, leave it out for now */
-    S390_FEAT_MSA_EXT_5,
/****** END FEATURE DEFS ******/

Reviewed-by: Thomas Huth <thuth@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]