[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/9] s390x/pci: add routine to get host function handle fr

From: Thomas Huth
Subject: Re: [PATCH v5 4/9] s390x/pci: add routine to get host function handle from CLP info
Date: Wed, 18 May 2022 10:13:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0

On 04/04/2022 20.17, Matthew Rosato wrote:
In order to interface with the underlying host zPCI device, we need
to know it's function handle.  Add a routine to grab this from the
vfio CLP capabilities chain.

Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
  hw/s390x/s390-pci-vfio.c         | 83 ++++++++++++++++++++++++++------
  include/hw/s390x/s390-pci-vfio.h |  6 +++
  2 files changed, 73 insertions(+), 16 deletions(-)
diff --git a/include/hw/s390x/s390-pci-vfio.h b/include/hw/s390x/s390-pci-vfio.h
index ff708aef50..0c2e4b5175 100644
--- a/include/hw/s390x/s390-pci-vfio.h
+++ b/include/hw/s390x/s390-pci-vfio.h
@@ -20,6 +20,7 @@ bool s390_pci_update_dma_avail(int fd, unsigned int *avail);
  S390PCIDMACount *s390_pci_start_dma_count(S390pciState *s,
                                            S390PCIBusDevice *pbdev);
  void s390_pci_end_dma_count(S390pciState *s, S390PCIDMACount *cnt);
+bool s390_pci_get_host_fh(S390PCIBusDevice *pbdev, uint32_t *fh);
  void s390_pci_get_clp_info(S390PCIBusDevice *pbdev);
  static inline bool s390_pci_update_dma_avail(int fd, unsigned int *avail)
@@ -33,6 +34,11 @@ static inline S390PCIDMACount 
*s390_pci_start_dma_count(S390pciState *s,
  static inline void s390_pci_end_dma_count(S390pciState *s,
                                            S390PCIDMACount *cnt) { }
+static inline bool s390_pci_get_host_fh(S390PCIBusDevice *pbdev,
+                                        unsigned int *fh)

This prototype does not match the one before the else - please replace "unsigned int" with "uint32_t".


+    return false;
  static inline void s390_pci_get_clp_info(S390PCIBusDevice *pbdev) { }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]