[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while i
|
From: |
Cornelia Huck |
|
Subject: |
Re: [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing |
|
Date: |
Thu, 23 Jun 2022 10:37:54 +0200 |
|
User-agent: |
Notmuch/0.36 (https://notmuchmail.org) |
On Thu, Jun 23 2022, Thomas Huth <thuth@redhat.com> wrote:
> According chapter "3.1.1 Driver Requirements: Device Initialization"
> of the Virtio specification (v1.1), a driver for a device has to set
> the ACKNOWLEDGE and DRIVER bits in the status field after resetting
> the device. The s390-ccw bios skipped these steps so far and seems
> like QEMU never cared. Anyway, it's better to follow the spec, so
> let's set these bits now in the right spots, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/virtio.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
The QEMU implementation seems to be pretty tolerant :)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>