[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] pc-bios/s390-ccw/virtio-blkdev: Simplify/fix virtio_ipl_

From: Thomas Huth
Subject: Re: [PATCH 1/2] pc-bios/s390-ccw/virtio-blkdev: Simplify/fix virtio_ipl_disk_is_valid()
Date: Fri, 24 Jun 2022 12:00:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 24/06/2022 11.20, Christian Borntraeger wrote:

Am 24.06.22 um 10:50 schrieb Thomas Huth:
The s390-ccw bios fails to boot if the boot disk is a virtio-blk
disk with a sector size of 4096. For example:

  dasdfmt -b 4096 -d cdl -y -p -M quick /dev/dasdX
  fdasd -a /dev/dasdX
  install a guest onto /dev/dasdX1 using virtio-blk
  qemu-system-s390x -nographic -hda /dev/dasdX1

Interestingly enough a real DASD (dasdX and not dasdX1) did work in the
past and I also successfully uses an NVMe disk. So I guess the NVMe
was 512 byte sector size then?

If you're using a full DASD, I think this was working thanks to the virtio_disk_is_eckd() function recognizing the geometry.

For NVMe disk - no clue. It either used 512 sectors, or it was at least accidentally still able to deal with the 512-byte sector requests after virtio_assume_scsi() "fixed" up the geometry. If you've got some spare minutes and still have access to those disks, it would be interesting to know if the boot still works there with my patches applied.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]