Re: [PATCH] target/s390x/tcg: SPX: check validity of new prefix

[David Hildenbrand]

On 27.06.22 19:06, Janis Schoetterl-Glausch wrote:
> On 6/27/22 18:27, David Hildenbrand wrote:
>> On 27.06.22 15:12, Janis Schoetterl-Glausch wrote:
>>> According to the architecture, SET PREFIX must try to access the new
>>> prefix area and recognize an addressing exception if the area is not
>>> accessible.
>>> For qemu this check prevents a crash in cpu_map_lowcore after an
>>> inaccessible prefix area has been set.
>>
>> I don't think that's possible. Our memory increments are 1 MiB and one
>> would have to cross a 1~MiB range with the second page to trigger that.
>> IIRC that's impossible with SPX address alignment requirements?
>>
> Are you saying that checking the first page is sufficient?

Yes, unless I'm wrong. :)

/* Due to alignment and QEMU memory sizes, it's sufficient to check the
first page only. */

> I'm not sure that this the case for the architecture in general,
> but I guess it is true for tcg. Do you want me to remove the second check?

Should have been clearer (and I somehow thought we'd be checking the
first page already :))

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb