[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] tests: wait for migration completion before looking for

From: Laurent Vivier
Subject: Re: [PATCH 2/5] tests: wait for migration completion before looking for STOP event
Date: Tue, 28 Jun 2022 14:47:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 28/06/2022 12:54, Daniel P. Berrangé wrote:
When moving into the convergance phase, the precopy tests will first
look for a STOP event and once found will look for migration completion
status. If the test VM is not converging, the test suite will be waiting
for the STOP event forever. If we wait for the migration completion
status first, then we will trigger the previously added timeout and
prevent the test hanging forever.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
  tests/qtest/migration-test.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index d33e8060f9..ac9e303b1f 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1232,6 +1232,10 @@ static void test_precopy_common(MigrateCommon *args)
migrate_set_parameter_int(from, "downtime-limit", CONVERGE_DOWNTIME); + /* We do this first, as it has a timeout to stop us
+         * hanging forever if migration didn't converge */
+        wait_for_migration_complete(from);
          if (!got_stop) {
              qtest_qmp_eventwait(from, "STOP");
@@ -1239,7 +1243,6 @@ static void test_precopy_common(MigrateCommon *args)
          qtest_qmp_eventwait(to, "RESUME");
-        wait_for_migration_complete(from);
if (args->finish_hook) {

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]