[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/9] exec/hwaddr.h: Add missing include

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/9] exec/hwaddr.h: Add missing include
Date: Tue, 20 Sep 2022 06:50:51 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 20/9/22 01:17, Bernhard Beschow wrote:
The next commit would not compile w/o the include directive.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
  include/exec/hwaddr.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h
index 8f16d179a8..616255317c 100644
--- a/include/exec/hwaddr.h
+++ b/include/exec/hwaddr.h
@@ -3,6 +3,7 @@
  #ifndef HWADDR_H
  #define HWADDR_H
+#include "qemu/osdep.h"

NAck: This is an anti-pattern. "qemu/osdep.h" must not be included
in .h, only in .c.

Isn't including "hw/qdev-core.h" in "include/hw/boards.h" enough in
the next patch?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]