[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState

From: B
Subject: Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState
Date: Thu, 22 Sep 2022 07:55:01 +0000

Am 21. September 2022 04:55:02 UTC schrieb Markus Armbruster 
>Bernhard Beschow <shentey@gmail.com> writes:
>> Am 20. September 2022 11:36:47 UTC schrieb Markus Armbruster 
>> <armbru@redhat.com>:
>>>Alistair Francis <alistair23@gmail.com> writes:
>>>> On Tue, Sep 20, 2022 at 9:18 AM Bernhard Beschow <shentey@gmail.com> wrote:
>>>>> SiFiveEState inherits from SysBusDevice while it's TypeInfo claims it to
>>>>> inherit from TYPE_MACHINE. This is an inconsistency which can cause
>>>>> undefined behavior such as memory corruption.
>>>>> Change SiFiveEState to inherit from MachineState since it is registered
>>>>> as a machine.
>>>>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>>>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>>>To the SiFive maintainers: since this is a bug fix, let's merge it right
>> I could repost this particular patch with the three new tags (incl. Fixes) 
>> if desired.
>Can't hurt, and could help the maintainers.

[X] Done.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]