[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/s390x: Fix emulation of the VISTR instruction

From: Thomas Huth
Subject: Re: [PATCH] target/s390x: Fix emulation of the VISTR instruction
Date: Tue, 11 Oct 2022 14:45:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 11/10/2022 14.30, David Hildenbrand wrote:
On 11.10.22 12:14, Thomas Huth wrote:
The element size is encoded in the M3 field, not in the M4
field. Let's also add a TCG test that shows the failing
behavior without this fix.

I'd suggest moving the test to a separate patch and adding a Fixes: tag to the fix.

Should be

Fixes: be6324c6b734 ("s390x/tcg: Implement VECTOR ISOLATE STRING")

Ok, can do!

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1248
Signed-off-by: Thomas Huth <thuth@redhat.com>
  tests/tcg/s390x/vf.c                | 50 +++++++++++++++++++++++++++++
  target/s390x/tcg/translate_vx.c.inc |  2 +-
  tests/tcg/s390x/Makefile.target     |  6 ++++
  3 files changed, 57 insertions(+), 1 deletion(-)
  create mode 100644 tests/tcg/s390x/vf.c

diff --git a/tests/tcg/s390x/vf.c b/tests/tcg/s390x/vf.c
new file mode 100644
index 0000000000..fdc424ce7c
--- /dev/null
+++ b/tests/tcg/s390x/vf.c

In general, we use "vx" when talking about vector extension. Maybe name this vx.c

Ok... or maybe "vecstring.c" in case we only want to test the vector string functions here? (they are in a separate chapter in the PoP)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]