Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

[Thomas Huth]

On 11/01/2023 11.09, Thomas Huth wrote:
> On 05/01/2023 15.53, Pierre Morel wrote:
> > The modification of the CPU attributes are done through a monitor
> > commands.
>
> s/commands/command/
>
> > It allows to move the core inside the topology tree to optimise
> > the cache usage in the case the host's hypervizor previously
>
> s/hypervizor/hypervisor/
>
> > moved the CPU.
> >
> > The same command allows to modifiy the CPU attributes modifiers
>
> s/modifiy/modify/
>
> > like polarization entitlement and the dedicated attribute to notify
> > the guest if the host admin modified scheduling or dedication of a vCPU.
> >
> > With this knowledge the guest has the possibility to optimize the
> > usage of the vCPUs.
>
> Hmm, who is supposed to call this QMP command in the future? Will there be a 
> new daemon monitoring the CPU changes in the host? Or will there be a 
> libvirt addition for this? ... Seems like I still miss the big picture here...

Or if this is just about to provide an API for future experiments, I'd 
rather suggest to introduce the new commands with a "x-" prefix to mark them 
as experimental (so we would also not need to go through the deprecation 
process in case they don't work out as expected in the future).

 Thomas