qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies


From: Daniel P . Berrangé
Subject: Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies
Date: Mon, 16 Jan 2023 10:46:02 +0000
User-agent: Mutt/2.2.9 (2022-11-12)

On Mon, Jan 16, 2023 at 10:06:07AM +0000, Alex Bennée wrote:
> 
> marcandre.lureau@redhat.com writes:
> 
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> I'm not sure how but this is re-breaking the windows build you just fixed:
> 
>   In file included from 
> /usr/x86_64-w64-mingw32/sys-root/mingw/include/epoxy/egl.h:46,
>                    from /tmp/qemu-test/src/include/ui/egl-helpers.h:5,
>                    from /tmp/qemu-test/src/include/ui/gtk.h:25,
>                    from ../src/ui/gtk.c:42:
>   /usr/x86_64-w64-mingw32/sys-root/mingw/include/epoxy/egl_generated.h:11:10: 
> fatal error: EGL/eglplatform.h: No such file or directory
>      11 | #include "EGL/eglplatform.h"
>         |          ^~~~~~~~~~~~~~~~~~~
>   compilation terminated.
> 
> I'm going to drop this patch for now.

We don't include mingw*-epoxy in the QEMU container, and AFAIK
nothing else we install has it as a dependency, so I'm guessing
you must have done a build locally rather than with our windows
containers ?

Ultimately this is a RPM packaging bug, which was recently fixed
in Fedora

commit 1e748f66e067d9332bc02f1ea994b6dd3b5e47f3 (HEAD -> f37, origin/rawhide, 
origin/main, origin/f37, origin/HEAD, rawhide)
Author: Kalev Lember <klember@redhat.com>
Date:   Fri Jan 13 14:36:35 2023 +0100

    Add missing runtime requires on mingw-angleproject
    
    This fixes gtk cross compilation in upstream CI that started to fail
    with:
    
    /usr/x86_64-w64-mingw32/sys-root/mingw/include/epoxy/egl_generated.h:11:10: 
fatal error: EGL/eglplatform.h: No such file or directory


So you should be able to just 'dnf update' to fix this.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]