Re: [PATCH v16 08/11] qapi/s390x/cpu topology: set-cpu-topology monitor command

[Pierre Morel]

On 2/24/23 18:15, Nina Schoetterl-Glausch wrote:
> On Wed, 2023-02-22 at 15:21 +0100, Pierre Morel wrote:
[...]
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index fbb5daf09b..d8c37808c7 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -1815,3 +1815,20 @@ SRST
> >     Dump the FDT in dtb format to *filename*.
> >   ERST
> >   #endif
> > +
> > +#if defined(TARGET_S390X)
> > +    {
> > +        .name       = "set-cpu-topology",
> > +        .args_type  = 
> > "core:l,socket:l?,book:l?,drawer:l?,entitlement:s?,dedicated:b?",
> Can you use ":O" for the ids? It would allow for some more flexibility.


I think it is better if let fall the hmp interface for the moment and 
will send it later in another series.

Regards,

Pierre