Re: [PATCH 04/12] target/s390x: Handle LRL and LGFRL from non-aligned ad

qemu-s390x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/12] target/s390x: Handle LRL and LGFRL from non-aligned ad

From:	Richard Henderson
Subject:	Re: [PATCH 04/12] target/s390x: Handle LRL and LGFRL from non-aligned addresses
Date:	Fri, 10 Mar 2023 11:28:17 -0800
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 3/10/23 09:42, Ilya Leoshkevich wrote:

Use MO_ALIGN_4 and let do_unaligned_access() generate a specification
exception.

Reported-by: Nina Schoetterl-Glausch<nsg@linux.ibm.com>
Suggested-by: Nina Schoetterl-Glausch<nsg@linux.ibm.com>
Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
---
  target/s390x/tcg/insn-data.h.inc | 14 +++++++-------
  target/s390x/tcg/translate.c     |  3 ++-
  2 files changed, 9 insertions(+), 8 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Note that both this and the previous could use MO_ALIGN, getting the required alignmentfrom the operand size.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/12] target/s390x: Handle unaligned accesses, Ilya Leoshkevich, 2023/03/10
- [PATCH 01/12] target/s390x: Handle branching to odd addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 01/12] target/s390x: Handle branching to odd addresses, Richard Henderson, 2023/03/10
    - Re: [PATCH 01/12] target/s390x: Handle branching to odd addresses, Ilya Leoshkevich, 2023/03/10
    - Re: [PATCH 01/12] target/s390x: Handle branching to odd addresses, Richard Henderson, 2023/03/10
- [PATCH 03/12] target/s390x: Handle LGRL from non-aligned addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 03/12] target/s390x: Handle LGRL from non-aligned addresses, Richard Henderson, 2023/03/10
- [PATCH 04/12] target/s390x: Handle LRL and LGFRL from non-aligned addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 04/12] target/s390x: Handle LRL and LGFRL from non-aligned addresses, Richard Henderson <=
- [PATCH 02/12] target/s390x: Handle EXECUTE of odd addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 02/12] target/s390x: Handle EXECUTE of odd addresses, Richard Henderson, 2023/03/10
- [PATCH 05/12] target/s390x: Handle LLGFRL from non-aligned addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 05/12] target/s390x: Handle LLGFRL from non-aligned addresses, Richard Henderson, 2023/03/10
- [PATCH 08/12] target/s390x: Handle CLRL and CLGFRL with non-aligned addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 08/12] target/s390x: Handle CLRL and CLGFRL with non-aligned addresses, Richard Henderson, 2023/03/10
- [PATCH 06/12] target/s390x: Handle CRL and CGFRL with non-aligned addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 06/12] target/s390x: Handle CRL and CGFRL with non-aligned addresses, Richard Henderson, 2023/03/10
- [PATCH 07/12] target/s390x: Handle CGRL and CLGRL with non-aligned addresses, Ilya Leoshkevich, 2023/03/10
  - Re: [PATCH 07/12] target/s390x: Handle CGRL and CLGRL with non-aligned addresses, Richard Henderson, 2023/03/10

Prev by Date: Re: [PATCH 03/12] target/s390x: Handle LGRL from non-aligned addresses
Next by Date: Re: [PATCH 05/12] target/s390x: Handle LLGFRL from non-aligned addresses
Previous by thread: [PATCH 04/12] target/s390x: Handle LRL and LGFRL from non-aligned addresses
Next by thread: [PATCH 02/12] target/s390x: Handle EXECUTE of odd addresses
Index(es):
- Date
- Thread