[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 2/9] target/i386: Check for USER_ONLY definition inste

From: Richard Henderson
Subject: Re: [RFC PATCH v2 2/9] target/i386: Check for USER_ONLY definition instead of SOFTMMU one
Date: Tue, 6 Jun 2023 07:47:08 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 6/5/23 15:24, Philippe Mathieu-Daudé wrote:
Since we *might* have user emulation with softmmu,
replace the system emulation check by !user emulation one.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  target/i386/tcg/translate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 5cf14311a6..750253e679 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -6915,7 +6915,7 @@ static void i386_tr_init_disas_context(DisasContextBase 
*dcbase, CPUState *cpu)
      dc->popl_esp_hack = 0;
      /* select memory access functions */
      dc->mem_index = 0;
      dc->mem_index = cpu_mmu_index(env, false);
      dc->cpuid_features = env->features[FEAT_1_EDX];

Alternately, remove the ifdef entirely.  The code is well-defined for user-only.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]