[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] target/arm: Rename helper template headers as '.h.inc'

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/5] target/arm: Rename helper template headers as '.h.inc'
Date: Tue, 6 Jun 2023 17:49:43 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2

On 6/6/23 16:37, Richard Henderson wrote:
On 6/6/23 07:12, Philippe Mathieu-Daudé wrote:
Since commit 139c1837db ("meson: rename included C source files
to .c.inc"), QEMU standard procedure for included C files is to
use *.c.inc.

Besides, since commit 6a0057aa22 ("docs/devel: make a statement
about includes") this is documented as the Coding Style:

   If you do use template header files they should be named with
   the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
   being included for expansion.

Therefore rename the included templates as '.h.inc'.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

FYI, after yesterday's tcg pr, we can do more than this.  These fragments no longer have to be all included into one common helper.h. Each translate-foo.c can include only the helper-foo.h.inc bits that they need, and the bits need not be visible to the rest of the front end.

Don't we need foo fully converted to decodetree first? Otherwise
generic translate code can call foo helpers, so needs their prototype

For example in translate-a64.c handle_msr_i(SVCR) calls
gen_helper_set_svcr() which is declared in helper-sme.h.

It was something that I had in mind when splitting include/exec/helper-gen.h, but the patch set was already large enough.

The renaming to .h.inc would have been the first step, anyway.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]