[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] target: Rename per-target 'helper.h' -> 'helper.h.inc'

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 4/5] target: Rename per-target 'helper.h' -> 'helper.h.inc'
Date: Thu, 8 Jun 2023 08:46:18 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2

On 6/6/23 16:43, Richard Henderson wrote:
On 6/6/23 07:12, Philippe Mathieu-Daudé wrote:
Since commit 139c1837db ("meson: rename included C source files
to .c.inc"), QEMU standard procedure for included C files is to
use *.c.inc.

Besides, since commit 6a0057aa22 ("docs/devel: make a statement
about includes") this is documented as the Coding Style:

   If you do use template header files they should be named with
   the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
   being included for expansion.

Therefore rename the included 'helper.h' as 'helper.h.inc' for
all targets (updating the documentation).

Suggested-by: Richard Henderson<richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>

A bulk patch like this isn't ideal.
Unfortunately these headers (declaring HELPER_H path) are used
by all targets:


So this has to be bulk.

Targets that have a tcg/ subdir should have helper.h.inc moved into there.


At the end, include/exec/helper-gen.h and include/exec/helper-proto.h become unused and go away.

Ah, you are suggesting to first inline these helpers in each target,
then move. Hmm OK I'll try.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]