[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pc-bios/s390-ccw/Makefile: Use -z noexecstack to silence lin

From: Christian Borntraeger
Subject: Re: [PATCH] pc-bios/s390-ccw/Makefile: Use -z noexecstack to silence linker warning
Date: Thu, 22 Jun 2023 15:12:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

Am 22.06.23 um 15:08 schrieb Thomas Huth:
Recent versions of ld complain when linking the s390-ccw bios:

  /usr/bin/ld: warning: start.o: missing .note.GNU-stack section implies
               executable stack
  /usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in
               a future version of the linker

We can silence the warning by telling the linker to mark the stack
as not executable.

Signed-off-by: Thomas Huth <thuth@redhat.com>
  pc-bios/s390-ccw/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
index 2e8cc015aa..acfcd1e71a 100644
--- a/pc-bios/s390-ccw/Makefile
+++ b/pc-bios/s390-ccw/Makefile
@@ -55,7 +55,7 @@ config-cc.mak: Makefile
            $(call cc-option,-march=z900,-march=z10)) 3> config-cc.mak
  -include config-cc.mak
-LDFLAGS += -Wl,-pie -nostdlib
+LDFLAGS += -Wl,-pie -nostdlib -z noexecstack
build-all: s390-ccw.img s390-netboot.img

In the end this should not matter as the resulting binary is not loaded by an
elf loader so this should be fine
Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]