[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] pc-bios/s390-ccw: Provide space for initial stack frame

From: Christian Borntraeger
Subject: Re: [PATCH 2/4] pc-bios/s390-ccw: Provide space for initial stack frame in start.S
Date: Mon, 26 Jun 2023 16:46:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

Am 26.06.23 um 15:21 schrieb Thomas Huth:
Providing the space of a stack frame is the duty of the caller,
so we should reserve 160 bytes before jumping into the main function.
Otherwise the main() function might write past the stack array.

While we're at it, add a proper STACK_SIZE macro for the stack size
instead of using magic numbers (this is also required for the following

Signed-off-by: Thomas Huth <thuth@redhat.com>
  pc-bios/s390-ccw/start.S | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index d29de09cc6..29b0a9ece0 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -10,10 +10,12 @@
   * directory.
+#define STACK_SIZE 0x8000
      .globl _start
- larl %r15,stack + 0x8000 /* Set up stack */
+    larl    %r15,stack + STACK_SIZE - 160   /* Set up stack */

Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]