[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S

From: Thomas Huth
Subject: Re: [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S
Date: Tue, 27 Jun 2023 08:55:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 26/06/2023 17.25, Richard Henderson wrote:
On 6/26/23 16:54, Christian Borntraeger wrote:

Am 26.06.23 um 15:21 schrieb Thomas Huth:

diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index 29b0a9ece0..47ef6e8aa8 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -120,3 +120,8 @@ external_new_mask:
      .quad   0x0000000180000000
      .quad   0x0000000180000000
+    .align  16
+    .lcomm  stack,STACK_SIZE

IIRC, the ELF ABI defines the stack to be 8 byte aligned, but 16 certainly does not hurt.

This doesn't do what you think it does.

.lcomm produces a COMMON symbol, which is merged with .bss at link time. Thus the .align does nothing.  Even switching to .bss section does nothing here.

You want

     .align 16
     .space    STACK_SIZE
     .size    stack, STACK_SIZE

Oh, thanks! I'll fix it in v2.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]