[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/21] hw/s390x/zpci-bus: Add QOM parentship relation with zP

From: Thomas Huth
Subject: Re: [PATCH 19/21] hw/s390x/zpci-bus: Add QOM parentship relation with zPCI devices
Date: Mon, 19 Feb 2024 14:38:16 +0100
User-agent: Mozilla Thunderbird

On 16/02/2024 12.03, Philippe Mathieu-Daudé wrote:
QDev objects created with qdev_*new() need to manually add
their parent relationship with object_property_add_child().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  hw/s390x/s390-pci-bus.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 3e57d5faca..6d07a7b530 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -934,6 +934,7 @@ static S390PCIBusDevice *s390_pci_device_new(S390pciState 
                                  "zPCI device could not be created: ");
          return NULL;
+    object_property_add_child(OBJECT(s), "zpci[*]", OBJECT(dev));

I think there can only be one zpci device per PCI device, so do we need the "[*]" here?


      if (!qdev_realize_and_unref(dev, BUS(s->bus), &local_err)) {
          error_propagate_prepend(errp, local_err,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]