[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH] ehci: Fix crash with isoc usb pac
From: |
Doug Goldstein |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH] ehci: Fix crash with isoc usb packets |
Date: |
Wed, 25 Sep 2013 16:22:57 -0500 |
On Mon, Sep 9, 2013 at 3:20 AM, Hans de Goede <address@hidden> wrote:
> The isoc packet path in the ehci code has a bad qobject cast, causing an
> abort, this patch fixes this.
>
> Note this problem is backported in 1.6.0 too, and this patch should be
> backported to the 1.6.0 stable tree.
>
> Signed-off-by: Hans de Goede <address@hidden>
> ---
> hw/usb/hcd-ehci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index 010a0d0..77c4872 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -1486,7 +1486,8 @@ static int ehci_process_itd(EHCIState *ehci,
> return -1;
> }
>
> - qemu_sglist_init(&ehci->isgl, DEVICE(ehci), 2, ehci->as);
> + qemu_sglist_init(&ehci->isgl, BUS(&ehci->bus)->parent,
> + 2, ehci->as);
> if (off + len > 4096) {
> /* transfer crosses page border */
> uint32_t len2 = off + len - 4096;
> --
> 1.8.3.1
>
>
Ping. Don't see this in master (and as such its missing from mdroth's
1.6.1 patch set).
--
Doug Goldstein
- Re: [Qemu-stable] [Qemu-devel] [PATCH] ehci: Fix crash with isoc usb packets,
Doug Goldstein <=