qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03


From: Andrey Korolyov
Subject: Re: [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03
Date: Wed, 3 Sep 2014 13:18:47 +0400

>
> OK so my patch fixes initialization likely by luck.
>
>> with crash still in place.
>
> Hmm so something is still wrong with the userspace path.
> Could you please apply this debugging patch on top of
> all the stack that is now working for you, and see if
> assert still surfaces?
>
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 1fe18c7..a8f8826 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -314,7 +314,10 @@ int vhost_net_start(VirtIODevice *dev, NetClientState 
> *ncs,
>      }
>
>      for (i = 0; i < total_queues; i++) {
> -        r = vhost_net_start_one(get_vhost_net(ncs[i].peer), dev);
> +        if (i > 0)
> +            r = -11;
> +        else
> +            r = vhost_net_start_one(get_vhost_net(ncs[i].peer), dev);
>
>          if (r < 0) {
>              goto err_start;
>

Yes, with Jason`s patch on the top and this one both acceleration and
re-initialization after reboot are broken, assert firing up again.
Will check if vhost_net: cleanup recovery works as intended and reply
to patch` thread.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]