[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests |
Date: |
Wed, 5 Oct 2016 09:02:58 -0400 (EDT) |
Hi
----- Original Message -----
-snip-
>
> I'd be willing to take this as is with a suitable TODO comment
> explaining where we want to go with this file. Perhaps
>
> /*
> * This program tests QMP commands that aren't interesting enough to
> * warrant their own test program.
> *
> * TODO The tests we got here now aren't good examples, because they
> * don't really exercise the commands, but only demonstrate specific
> * bugs we've fixed.
> */
>
> What do you think?
It looks like a comment that may stale. I have a few tests in some wip branch
that will go naturally there, so I hope it won't remain bug-fix only checks. I
can't say how long it will take to get there though, so I am fine with a
comment anyway, perhaps without TODO?
thanks