[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [Qemu-devel] [PATCH] target/arm: Free TCG temps in tra
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-stable] [Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp() |
|
Date: |
Thu, 29 Aug 2019 19:53:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 8/27/19 2:19 PM, Peter Maydell wrote:
> The function neon_store_reg32() doesn't free the TCG temp that it
> is passed, so the caller must do that. We got this right in most
> places but forgot to free the TCG temps in trans_VMOV_64_sp().
>
> Cc: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target/arm/translate-vfp.inc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c
> index 3e8ea80493b..9ae980bef63 100644
> --- a/target/arm/translate-vfp.inc.c
> +++ b/target/arm/translate-vfp.inc.c
> @@ -880,8 +880,10 @@ static bool trans_VMOV_64_sp(DisasContext *s,
> arg_VMOV_64_sp *a)
> /* gpreg to fpreg */
> tmp = load_reg(s, a->rt);
> neon_store_reg32(tmp, a->vm);
> + tcg_temp_free_i32(tmp);
> tmp = load_reg(s, a->rt2);
> neon_store_reg32(tmp, a->vm + 1);
> + tcg_temp_free_i32(tmp);
> }
>
> return true;
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>