[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 17/19] tcg: save vaddr temp for plugin usage
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2 17/19] tcg: save vaddr temp for plugin usage |
Date: |
Sun, 16 Feb 2020 01:23:58 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/13/20 2:51 PM, Alex Bennée wrote:
> From: Richard Henderson <address@hidden>
>
> While do_gen_mem_cb does copy (via extu_tl_i64) vaddr into a new temp
> this won't help if the vaddr temp gets clobbered by the actual
> load/store op. To avoid this clobbering we explicitly copy vaddr
> before the op to ensure it is live my the time we do the
> instrumentation.
>
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> Cc: address@hidden
> ---
> tcg/tcg-op.c | 23 ++++++++++++++++++++---
> 1 file changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~