[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] block/qcow2-threads: fix qcow2_decompress

From: Ján Tomko
Subject: Re: [PATCH] block/qcow2-threads: fix qcow2_decompress
Date: Wed, 4 Mar 2020 15:24:47 +0100

On a Monday in 2020, Vladimir Sementsov-Ogievskiy wrote:
On success path we return what inflate() returns instead of 0. And it
most probably works for Z_STREAM_END as it is positive, but is
definitely broken for Z_BUF_ERROR.

While being here, switch to errno return code, to be closer to
qcow2_compress API (and usual expectations).

Revert condition in if to be more positive. Drop dead initialization of

Cc: address@hidden # v4.0
Fixes: 341926ab83e2b
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>


Reviewing Den's series about zstd in qcow2 support, I found an existing
bug. Let's fix it. This is to be a new base of zstd series.

block/qcow2-threads.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: Ján Tomko <address@hidden>


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]