[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 for-5.0] xen-block: Fix double qlist remove and request le
Re: [PATCH v2 for-5.0] xen-block: Fix double qlist remove and request leak
Tue, 7 Apr 2020 13:50:36 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0
On 06.04.20 16:02, Anthony PERARD wrote:
> Commit a31ca6801c02 ("qemu/queue.h: clear linked list pointers on
> remove") revealed that a request was removed twice from a list, once
> in xen_block_finish_request() and a second time in
> xen_block_release_request() when both function are called from
> xen_block_complete_aio(). But also, the `requests_inflight' counter is
> decreased twice, and thus became negative.
> This is a bug that was introduced in bfd0d6366043, where a `finished'
> list was removed.
> That commit also introduced a leak of request in xen_block_do_aio().
> That function calls xen_block_finish_request() but the request is
> never released after that.
> To fix both issue, we do two changes:
> - we squash finish_request() and release_request() together as we want
> to remove a request from 'inflight' list to add it to 'freelist'.
> - before releasing a request, we need to let now the result to the
> other end, thus we should call xen_block_send_response() before
> releasing a request.
> The first change fix the double QLIST_REMOVE() as we remove the extra
> call. The second change makes the leak go away because if we want to
> call finish_request(), we need to call a function that do all of
> finish, send response, and release.
> Fixes: bfd0d6366043 ("xen-block: improve response latency")
> Signed-off-by: Anthony PERARD <address@hidden>
> hw/block/dataplane/xen-block.c | 48 ++++++++++++----------------------
> 1 file changed, 16 insertions(+), 32 deletions(-)
I’m going to send a pull request today anyway, so I hope you won’t mind
and let me take this patch to my branch (with Paul’s suggestions
Description: OpenPGP digital signature