|
From: | Eric Blake |
Subject: | Re: [PATCH v2 0/1] qemu-nbd: Close inherited stderr |
Date: | Fri, 15 May 2020 12:31:24 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/15/20 1:36 AM, Raphael Pour wrote:
From e5749541494abcdcaa37d752172741e1bc38e984 Mon Sep 17 00:00:00 2001From: Raphael Pour <address@hidden> Date: Fri, 15 May 2020 08:30:50 +0200 Subject: [PATCH] qemu-nbd: Close inherited stderr Close inherited stderr of the parent if fork_process is false. Otherwise no one will close it. (introduced by e6df58a5) Signed-off-by: Raphael Pour <address@hidden> --- qemu-nbd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Thanks. It might have been easier posting this as a standalone v3 rather than buried in reply to v2, but I have now queued it to go in through my NBD tree (I plan on doing a pull request Monday).
I've also taken the liberty to amend the commit message as follows, to give more context into why the fix is needed:
qemu-nbd: Close inherited stderr Close inherited stderr of the parent if fork_process is false. Otherwise no one will close it. (introduced by e6df58a5) This only affected 'qemu-nbd -c /dev/nbd0'. Signed-off-by: Raphael Pour <address@hidden> Message-Id: <address@hidden> Reviewed-by: Eric Blake <address@hidden> [eblake: Enhance commit message] Signed-off-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |