Re: [PATCH 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS

[Greg Kurz]

On Wed, 20 Apr 2022 12:28:01 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:

> On Mittwoch, 20. April 2022 11:09:46 CEST Greg Kurz wrote:
> > On Tue, 19 Apr 2022 13:41:03 +0200
> > 
> > Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > > mknod() on macOS does not support creating sockets, so divert to
> > > call sequence socket(), bind() and chmod() respectively if S_IFSOCK
> > > was passed with mode argument.
> > 
> > Hmm... thinking again about this one : QEMU on linux calls the libc
> > version of mknodat() which doesn't seem to support S_IFSOCK according
> > to the mknod(3P) manual page. So I'm not sure there's something to
> > be actually fixed here... what's the observed behavior on linux ?
> 
> It's unclear to me where you got that from. In all Linux man pages I looked 
> up 
> so far it said S_IFSOCK was supported. But I also tested this now with 
> security_model=none on a Linux host and it works as expected, i.e. it creates 
> a file of type socket on the Linux host filesystem.
> 
> We are really talking about a Linux host, right?
> 

Yes but you can forget this remark. I've checked the glibc sources
and it directly calls the syscall... I guess I got confused by the
mknod(3P) manual page. Sorry for the noise :-)

> Best regards,
> Christian Schoenebeck
> 
>