[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/5] migration/ram: Fix error handling in ram_write_tracki
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v1 2/5] migration/ram: Fix error handling in ram_write_tracking_start() |
|
Date: |
Thu, 02 Feb 2023 12:16:11 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
David Hildenbrand <david@redhat.com> wrote:
> If something goes wrong during uffd_change_protection(), we would miss
> to unregister uffd-wp and not release our reference. Fix it by
> performing the uffd_change_protection(true) last.
>
> Note that a uffd_change_protection(false) on the recovery path without a
> prior uffd_change_protection(false) is fine.
>
> Fixes: 278e2f551a09 ("migration: support UFFD write fault processing in
> ram_save_iterate()")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v1 2/5] migration/ram: Fix error handling in ram_write_tracking_start(),
Juan Quintela <=