qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 2/4] migration/multifd: Fix p->iov leak in multifd-uadk.c


From: Michael Tokarev
Subject: Re: [PATCH v7 2/4] migration/multifd: Fix p->iov leak in multifd-uadk.c
Date: Fri, 6 Sep 2024 18:06:16 +0300
User-agent: Mozilla Thunderbird

28.08.2024 17:56, Fabiano Rosas wrote:
The send_cleanup() hook should free the p->iov that was allocated at
send_setup(). This was missed because the UADK code is conditional on
the presence of the accelerator, so it's not tested by default.

Fixes: 819dd20636 ("migration/multifd: Add UADK initialization")
Reported-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
  migration/multifd-uadk.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/migration/multifd-uadk.c b/migration/multifd-uadk.c
index 89f6a72f0e..6e6a290ae9 100644
--- a/migration/multifd-uadk.c
+++ b/migration/multifd-uadk.c
@@ -132,6 +132,8 @@ static void multifd_uadk_send_cleanup(MultiFDSendParams *p, 
Error **errp)
multifd_uadk_uninit_sess(wd);
      p->compress_data = NULL;
+    g_free(p->iov);
+    p->iov = NULL;
  }

This sounds like something for stable-9.1.x, is it not?

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]