[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH v2] configure: Don't create symlinks to nonexisten

From: Peter Maydell
Subject: [Qemu-trivial] [PATCH v2] configure: Don't create symlinks to nonexistent targets
Date: Wed, 25 May 2011 18:30:17 +0100

When we create the symlinks to source tree files, don't create them
if the file is not actually present in the source tree; this will
happen if the file is in a git submodule that wasn't checked out.

This also avoids the odd effect where an in-source-tree configure
will end up creating the missing file as a symlink to itself.

Signed-off-by: Peter Maydell <address@hidden>
v2: Remove the debug printing. Oops.

 configure |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index a318d37..a648f3d 100755
--- a/configure
+++ b/configure
@@ -3564,7 +3564,9 @@ for bios_file in $source_path/pc-bios/*.bin 
$source_path/pc-bios/*.rom $source_p
 mkdir -p $DIRS
 for f in $FILES ; do
-    test -e $f || symlink $source_path/$f $f
+    if [ -e "$source_path/$f" -a ! -e "$f" ]; then
+        symlink "$source_path/$f" "$f"
+    fi
 # temporary config to build submodules

reply via email to

[Prev in Thread] Current Thread [Next in Thread]