[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix compilation warning due to m

From: Alexandre Raymond
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction
Date: Thu, 2 Jun 2011 09:27:42 -0400

On Thu, Jun 2, 2011 at 6:13 AM, Andreas Färber <address@hidden> wrote:
> Am 02.06.2011 um 04:21 schrieb Alexandre Raymond:
>> Fix the following warning by including signal.h directly in qemu-common.h
>> ----8<----
>> iohandler.c: In function ‘qemu_init_child_watch’:
>> iohandler.c:172: warning: implicit declaration of function ‘sigaction’
>> iohandler.c:172: warning: nested extern declaration of ‘sigaction’
>> ----8<----
>> Signed-off-by: Alexandre Raymond <address@hidden>
> Tested-by: Andreas Färber <address@hidden>
> Why in qemu-common.h and not in iohandler.c though?
> If we put it into qemu-common.h, you should remove other inclusions of
> signal.h.

Well, I was simply following Anthony's advice from "[PATCH] #include
cleanlines" : "The idea behind qemu-common.h is to avoid direct
includes to help with portability."


reply via email to

[Prev in Thread] Current Thread [Next in Thread]