[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] Make x86 mfence and lfence illegal without SSE2

From: Martin Simmons
Subject: [Qemu-trivial] [PATCH] Make x86 mfence and lfence illegal without SSE2
Date: Mon, 6 Jun 2011 15:49:17 +0100 (BST)


While trying to use qemu -cpu pentium3 to test for incorrect uses of certain
SSE2 instructions, I found that QEMU allowed the mfence and lfence
instructions to be executed even though Pentium 3 doesn't support them.

According to the processor specs (and experience on a real Pentium 3), these
instructions are only available with SSE2, but QEMU is checking for SSE.  The
check for the related sfence instruction is correct (it works with SSE).

This trival patch fixes the test:

Signed-off-by: Martin Simmons <address@hidden>

--- a/target-i386/translate.c   2011-06-03 16:17:18.270208646 +0100
+++ b/target-i386/translate.c   2011-06-03 16:02:41.381556714 +0100
@@ -7560,7 +7560,7 @@
         case 5: /* lfence */
         case 6: /* mfence */
-            if ((modrm & 0xc7) != 0xc0 || !(s->cpuid_features & CPUID_SSE))
+            if ((modrm & 0xc7) != 0xc0 || !(s->cpuid_features & CPUID_SSE2))
                 goto illegal_op;
         case 7: /* sfence / clflush */


reply via email to

[Prev in Thread] Current Thread [Next in Thread]