[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64

From: Stefan Weil
Subject: Re: [Qemu-trivial] [PATCH] Avoid double definitions of PRI*64
Date: Thu, 23 Jun 2011 16:32:25 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110505 Iceowl/1.0b1 Icedove/3.0.11

Am 23.06.2011 15:35, schrieb Stefan Hajnoczi:
On Thu, Jun 23, 2011 at 10:15:58AM +0200, Jan Kiszka wrote:
From: Jan Kiszka <address@hidden>

Recent mingw32 provide those defines.

... and all of those defines are wrong, because QEMU does not use
MS format specifiers. http://patchwork.ozlabs.org/patch/74276/
tried to fix this. My preferred solution is removing those PRI*64 from
qemu-common.h, because not only recent mingw32 versions provide
the (wrong) definitions, but even the Debian version provides them
(which is really old, but I use it for my regression tests).

The wrong definitions do not allow using -Wformat for mingw32
builds, but they work because (most?) relevant mingw32 functions
accept both MS and standard format specifiers.

Adding the correct definitions (to qemu-os-win32.h, not to qemu-common.h)
would be another solution as long as mingw32 does not handle

Signed-off-by: Jan Kiszka <address@hidden>
qemu-common.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

It's never too late to implement C99!

Thanks, applied to the trivial patches tree:


Stefan, the patch won't harm, but it's also unnecessary.
So it's up to you whether you remove it from your queue,
modify it as I suggested above or apply it as it is.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]