[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code
Date: Mon, 25 Jul 2011 11:22:16 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jul 20, 2011 at 08:56:35PM +0200, Stefan Weil wrote:
> cppcheck reports this error:
> qemu/hw/sh_intc.c:390: error: Possible null pointer dereference:
>  s - otherwise it is redundant to check if s is null at line 385
> If s were NULL, the printf() statement would crash.
> Setting braces fixes this bug.
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  hw/sh_intc.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)

Aurelien Jarno is listed as active maintainer for this code.  Patches
should go through him.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]