[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 2/2] hw/9pfs: Supply missing va_end()

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH 2/2] hw/9pfs: Supply missing va_end()
Date: Mon, 31 Oct 2011 11:51:32 +0000

On Fri, Oct 28, 2011 at 9:52 AM, Markus Armbruster <address@hidden> wrote:
> C99 7.15.1: Each invocation of the va_start and va_copy macros shall
> be matched by a corresponding invocation of the va_end macro in the
> same function.
> Spotted by Coverity.  Harmless on the (common) systems where va_end()
> does nothing.
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hw/9pfs/virtio-9p.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)

Thanks for this patch.  I looked at the surrounding code and it turns
out this entire function duplicates g_vasprintf() from glib.

I sent a patch to use g_vasprintf() and it therefore eliminates the
varargs issue.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]