[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-barrier: Fix build failure

From: Anthony Liguori
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X
Date: Tue, 01 Nov 2011 13:04:35 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 11/01/2011 04:39 AM, Eric Sunshine wrote:
qemu-barrier.h tests if macro __powerpc__ is defined, however, the
preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
__powerpc__.  Resolve by testing instead for qemu-provided _ARCH_PPC.

Signed-off-by: Eric Sunshine<address@hidden>

Applied.  Thanks.


Anthony Liguori


The anomalous __powerpc__ test appears only in qemu-barrier.h.
No other source files reference this name.

Cc: David Gibson<address@hidden>

  qemu-barrier.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-barrier.h b/qemu-barrier.h
index 735eea6..c11bb2b 100644
--- a/qemu-barrier.h
+++ b/qemu-barrier.h
@@ -14,7 +14,7 @@
  #define smp_wmb()   barrier()

-#elif defined(__powerpc__)
+#elif defined(_ARCH_PPC)

   * We use an eieio() for a wmb() on powerpc.  This assumes we don't

reply via email to

[Prev in Thread] Current Thread [Next in Thread]