[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] ui/vnc: Convert sasl.mechlist

From: Kevin Wolf
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] ui/vnc: Convert sasl.mechlist to g_malloc() & friends
Date: Tue, 08 Nov 2011 15:44:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0

Am 08.11.2011 15:34, schrieb 陳韋任:
>> Stefan Hajnoczi <address@hidden> writes:
>>> On Tue, Nov 8, 2011 at 12:45 PM, Markus Armbruster <address@hidden> wrote:
>>>> Fixes protocol_client_auth_sasl_mechname() not to crash when malloc()
>>>> fails.  Spotted by Coverity.
>>>> ---
>>>>  ui/vnc-auth-sasl.c |   19 +++++--------------
>>>>  1 files changed, 5 insertions(+), 14 deletions(-)
>>> Looks good, please add Signed-off-by.
>> Gaa, too trivial to get it right in less than three tries!  There must a
>> curse of brainlessness on this one...
>   `git-format-patch -s` will generate the sign-off-by.

And git commit -s will make sure that it doesn't disappear in v2 when it
was there in v1.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]