[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] monitor: Fix file_completion() to check for s

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] monitor: Fix file_completion() to check for stat() failure
Date: Fri, 18 Nov 2011 11:24:29 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Nov 16, 2011 at 03:43:47PM +0100, Markus Armbruster wrote:
> stat() can fail for a file name just read with readdir().  Easiest way
> to trigger is a dangling symbolic link --- look ma, no race!  When it
> fails, file_completion() uses sb.st_mode uninitialized.  If the
> directory bit happens to be set, it appends a "/" to the completed
> name.
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  monitor.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:

I have already sent a pull request including this patch for QEMU 1.0.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]