[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] darwin-user: Fix format string i

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] darwin-user: Fix format string in debug message
Date: Tue, 22 Nov 2011 10:57:16 +0000

On 22 November 2011 10:43, Stefan Hajnoczi <address@hidden> wrote:
> On Sat, Nov 19, 2011 at 08:18:39PM +0100, Stefan Weil wrote:
>> This was spotted by cppcheck.
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>>  darwin-user/signal.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
> I am waiting to see if you send a v2 or this thread continues.  Not
> applied to trivial-patches.

FWIW I think the patch as it is is fine. We have already printed
sa_handler &c in the immediately preceding line of debug output so
there's nothing gained from printing them again; probably it was
a stray cut-n-paste error in the first place.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]