[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial mem
From: |
Blue Swirl |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename() |
Date: |
Thu, 17 Jan 2013 20:49:04 +0000 |
On Wed, Jan 16, 2013 at 4:06 PM, Markus Armbruster <address@hidden> wrote:
> Eric Blake <address@hidden> writes:
>
>> On 01/16/2013 07:36 AM, Markus Armbruster wrote:
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>> ---
>>> qemu-log.c | 13 +++++++++----
>>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/qemu-log.c b/qemu-log.c
>>> index 64a1b88..1eadf1b 100644
>>> --- a/qemu-log.c
>>> +++ b/qemu-log.c
>>> @@ -21,10 +21,12 @@
>>> #include "qemu/log.h"
>>>
>>> #ifdef WIN32
>>> -static const char *logfilename = "qemu.log";
>>> +#define DEFAULT_LOGFILENAME = "qemu.log"
>>
>> Syntax error.
>
> How embarrassing. Unfortunately, it compiles... I'll respin.
>
>>> @@ -54,11 +56,13 @@ void qemu_log_mask(int mask, const char *fmt, ...)
>>> /* enable or disable low levels log */
>>> void qemu_set_log(int log_flags, bool use_own_buffers)
>>> {
>>> + const char *fname = logfilename ?: DEFAULT_LOGFILENAME;
>>
>> ?: is not C99, but a GNU extension. What is our policy on using it?
>
> We got several dozen instancess of ?: spread over the tree.
I'd not add any more. It's a bad idea to add more dependencies to
specific tools than is necessary.
- [Qemu-trivial] [PATCH 00/11] Trivial memory allocation fixes & cleanups, Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 07/11] qemu-log: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 05/11] spice: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 02/11] g_strdup(NULL) returns NULL; simplify, Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify, Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 04/11] readline: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] Trivial memory allocation fixes & cleanups, Eric Blake, 2013/01/16
- [Qemu-trivial] [PATCH 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH 10/11] qapi: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16