[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_a

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PULL 10/17] target-m68k: Replace qemu_assert by hw_error
Date: Wed, 1 Jan 2014 15:29:59 +0000

On 1 January 2014 13:56, Stefan Weil <address@hidden> wrote:
> hw_error is not available for user mode, so this patch fixes Darwin
> (which only provides system emulation), but it breaks linking of
> m68k-linux-user on Linux hosts.

Maybe we need to come up with some better guidelines
about when to use the various choices of API we have
for fatal and otherwise unexpected errors:
 * hw_error
 * qemu_log_mask(LOG_UNIMP, ...) and continue
 * assert
 * g_assert and friends
 * error*
 * qerror*
 * abort
 * tcg_abort
 * probably others I forget about...

At the moment there's a bit of a mix in existing code, and I don't
really know what the "best practices" are for when I'm reviewing
new code.

PS: does anybody actually find the full register dump hw_error()
spits out useful?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]