[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v3 2/2] vl: convert -m to QemuOpts

From: Eric Blake
Subject: Re: [Qemu-trivial] [PATCH v3 2/2] vl: convert -m to QemuOpts
Date: Wed, 05 Mar 2014 13:33:43 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 03/05/2014 09:10 AM, Igor Mammedov wrote:
> Adds option to -m
>  "size" - startup memory amount
> For compatibility with legacy CLI if suffix-less number is passed,
> it assumes amount in Mb.
> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> v2:
>  - suggested by Andreas Färber <address@hidden>
>     * s/fprintf/error_report/
>     * rename 'mem' option to 'size'
>  - fix conflict with missing numa QemuOpts

Given the amount of rework in v2, it may have been smarter to drop my
R-b tag.  But beyond Andreas' findings of missing s/mem/size/ instances,
I'm not spotting any problems, so if that's the only fix you make for
v4, you can keep my R-b.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]