[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] Virtual VFAT with floppy option doesn't

From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] Virtual VFAT with floppy option doesn't work
Date: Thu, 27 Mar 2014 13:30:34 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Kiyokazu SUTO <address@hidden> writes:

> Hi,
> Virtual VFAT mechanism in recent releases does not work with the
> floppy option, because, in `vvfat_open()' function, the member
> `first_sectors_number' is overwritten with the value for HDD even when
> the floppy option presents.  I attach the diff output just to clarify
> the problem.
> Sorry if this has been already fixed in the git repository.

Your fix is correct, but the patch doesn't pass checkpatch, it doesn't
have a proper commit message, and it lacks your S-o-B.  Since the fix is
trivial, and we're very close to the release, I'm going to redo it.
Hope you don't mind.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]